This repository has been archived by the owner on Sep 25, 2018. It is now read-only.
Add application menu #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expbot
pushed a commit
that referenced
this pull request
Nov 15, 2016
* [xde] Build XDE with Webpack Build XDE with Webpack. Benefits: - Adds HMR capabilities - Tree shaking with web pack 2 - Potential other optimizations in the future that I haven't thought of yet. Key points: - Keeps node_modules in `app` unbundled -- at the moment, there's no benefit in bundling them. - Uses source maps to keep debug-ability (for some reason source-map support was turned off in Chrome Developer Tools in Electron for me...make sure to turn it on) - You can run with hot module reloading turned off or on -- run `npm run start[-local | -staging]-hot` to use it, omit the `-hot` to not. - Modified npm scripts so that you don't have to run any watcher script separately. Just run the correct `npm run start-blahblahblha` command and go. - No need to `yarn` in both directories -- `yarn` in `dev/xde` will use a postinstall script to `yarn` in the `dev/xde/app` directory and also rebuild any node_modules using electron rebuild. - When bundling with Webpack, don't transpile commonJS modules -- Webpack understands these and uses them to do tree shaking. - Temporarily, we need to use the `es2015` preset with babel when using HMR -- there is a bug: gaearon/react-hot-loader#391 cc @jesseruder @ide * [xde] Install React Developer Tools * [xde] Update yarn.lock. * [XDE] Fix native dependency installation, update Electron * [xde] Rebuild when app starts, not on install * [xde] Fix dirname issue in renderer * [xde] Clean up gulp + webpack config * Fix yarn * [xde] Fixup babel/HMR config * re yarn * s/index/renderer * separate entry point for HMR fbshipit-source-id: f4e811b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15