Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remotes popup #2350

Merged
merged 15 commits into from
Sep 18, 2024
Merged

Remotes popup #2350

merged 15 commits into from
Sep 18, 2024

Conversation

robin-thoene
Copy link
Contributor

@robin-thoene robin-thoene commented Sep 3, 2024

This Pull Request fixes/closes #2172 .

It changes the following:

  • new popups to interact with git remotes to
    • view remotes
    • add a new remote
    • edit an existing remote name
    • edit an existing remote url
    • delete an existing remote

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@extrawurst

This comment was marked as resolved.

@extrawurst
Copy link
Owner

extrawurst commented Sep 17, 2024

a command to fetch only the selected remote would be great (followup, but can reuse fetch popup)

@extrawurst

This comment was marked as resolved.

@extrawurst

This comment was marked as resolved.

Copy link
Owner

@extrawurst extrawurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok i finally had time for an in-depth review. i love this feature already just for reviewing PRs :)
Lets get it over the finish line. i believe my remarks are all no biggies but should be addressed before we can merge it.
good job!

CHANGELOG.md Outdated Show resolved Hide resolved
src/popups/create_remote.rs Outdated Show resolved Hide resolved
src/popups/remotelist.rs Show resolved Hide resolved
src/popups/remotelist.rs Outdated Show resolved Hide resolved
src/popups/remotelist.rs Show resolved Hide resolved
src/strings.rs Outdated Show resolved Hide resolved
@robin-thoene robin-thoene force-pushed the remotes-popup branch 3 times, most recently from 735c147 to 0eee47f Compare September 17, 2024 15:41
@robin-thoene

This comment was marked as outdated.

@robin-thoene

This comment was marked as resolved.

@extrawurst

This comment was marked as outdated.

@extrawurst

This comment was marked as resolved.

@extrawurst

This comment was marked as resolved.

@extrawurst

This comment was marked as resolved.

@extrawurst

This comment was marked as resolved.

@extrawurst

This comment was marked as resolved.

CHANGELOG.md Outdated Show resolved Hide resolved
@extrawurst extrawurst merged commit d4f9400 into extrawurst:master Sep 18, 2024
21 checks passed
@extrawurst
Copy link
Owner

Thank you so much 🎉

@robin-thoene
Copy link
Contributor Author

Thank you so much for the review, guidance and help!

@robin-thoene robin-thoene deleted the remotes-popup branch September 23, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Remotes Popup
2 participants