Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(completions): remove stray backslashes #303

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix(completions): remove stray backslashes #303

merged 2 commits into from
Sep 13, 2023

Conversation

aidandenlinger
Copy link
Contributor

@aidandenlinger aidandenlinger commented Sep 13, 2023

Grep 3.8 causes warnings on regular expressions with stray backslashes:

Regular expressions with stray backslashes now cause warnings, as
their unspecified behavior can lead to unexpected results.
For example, '\a' and 'a' are not always equivalent
https://bugs.gnu.org/39678... The warnings are intended as a
transition aid; they are likely to be errors in future releases.

On a fresh Fedora 38 container with grep 3.8, this results in warnings showing up in the terminal when trying to use the bash completions:

Grep errors appearing in the terminal when using bash completions

I can't say why these particular backslashes are stray backslashes, but removing them results in the completions working without any errors:

The bash completions working without errors with the changes from this PR

@aidandenlinger aidandenlinger changed the title fix(completions): remove straying backslashes fix(completions): remove stray backslashes Sep 13, 2023
Grep 3.8 causes warnings on regular expressions
with stray backslashes.
@PThorpe92
Copy link
Member

Although the current completions worked for me with a fresh bash setup (I normally use nu or fish), I tested this and it works as expected. So if it works for both sets of users, then LGTM 👍

Thanks for your contribution :)

@cafkafk cafkafk merged commit 9adfa60 into eza-community:main Sep 13, 2023
@aidandenlinger aidandenlinger deleted the completions_fix branch September 13, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants