Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small typo this -> that #380

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Small typo this -> that #380

merged 1 commit into from
Sep 19, 2023

Conversation

bew
Copy link
Contributor

@bew bew commented Sep 18, 2023

No description provided.

@bew bew requested a review from cafkafk as a code owner September 18, 2023 21:02
@9glenda
Copy link
Member

9glenda commented Sep 18, 2023

@bew the CI is failing because your commit message is not using Conventional Commits

cafkafk
cafkafk approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, LGTM 👍

@cafkafk cafkafk merged commit 5c92950 into eza-community:main Sep 19, 2023
@bew bew deleted the patch-2 branch September 19, 2023 03:13
@razvanazamfirei razvanazamfirei mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cafkafk cafkafk cafkafk approved these changes

@9glenda 9glenda 9glenda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Eza Pull-Requests
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bew @9glenda @cafkafk