Allow dynamic properties in CurlMultiHandler for PHP 8.2 support #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
fredden
reviewed
Oct 11, 2022
| @@ -16,6 +16,7 @@ | |||
| * | |||
| * @property resource $_mh Internal use only. Lazy loaded multi-handle. | |||
| */ | |||
| #[AllowDynamicProperties] | |||
There was a problem hiding this comment.
Or declare the properties that are used?
There was a problem hiding this comment.
I did look at that, but the lazy loading $_mh is a world of pain that would need some significant refactoring 😱
|
@ezimuel can we get this merged? It's annoying in the CI 🙈 |
|
Thanks @asgrim for your help. |
|
Just released version 1.2.1 https://github.com/ezimuel/ringphp/releases/tag/1.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the deprecation notice:
Note: this PR does not fix or even check anything else with PHP 8.2 compatibility; just this specific issue.