docs/clean: formally deprecate rollupCommonJSResolveHack
#367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Formally deprecate
rollupCommonJSResolveHack
as it's been obsolete since 0.30.0Details
this has had no effect since Fix duplicate output with multiple entry points on Windows (host normalization) #251
rollupCommonJSResolveHack
would make no difference eithertrue
orfalse
true
nowformally state now that this is deprecated in the docs
also add a warning in
options
similar to the existing one forobjectHashIgnoreUnknownHack
(from cd76b42, which was added to my first major contribution back in (fix): upgrade object-hash to support async/await syntax #203 🙂 )remove the
resolve
dependency as wellpackage-lock.json
resolve
was never needed anyway as we could've used NodeJS's nativepath.resolve
orrequire.resolve
instead (noted this at the bottom of rpt2 does not resolve pnpm symlinked dependencies #234 (comment))resolve
was created forbrowserify
after all, where one can't use NodeJS APIspath.resolve
andrequire.resolve
References
resolveId
paths? rollup/rollup#2952 seems to be a more-or-less equivalent issue as wellrollup-plugin-commonjs
: namedExports is using non-normalized resolved module path as module id rollup/rollup-plugin-commonjs#177commonjs
is internally consistent, it shouldn't matter what kind of paths are passed to it, as it is normalized to the same string either way10.1.0
, which seems to have been the last version before the move to@rollup/plugin-commonjs