Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing an eZOrder should also remove its eZOrderItems #1460

Open
wants to merge 1 commit into
base: 2019.03
Choose a base branch
from
Open

Removing an eZOrder should also remove its eZOrderItems #1460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions kernel/classes/ezorder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1353,6 +1353,7 @@ static function cleanupOrder( $orderID )
$db = eZDB::instance();
$db->begin();
$db->query( "DELETE FROM ezorder where id='$orderID'" );
$db->query( "DELETE FROM ezorder_item WHERE order_id=$orderID" );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at line below, should this have been:

Suggested change
$db->query( "DELETE FROM ezorder_item WHERE order_id=$orderID" );
$db->query( "DELETE FROM ezorder_item WHERE order_id=$orderNr" );

??

$db->query( "DELETE FROM ezproductcollection where id='$productCollectionID'" );
$db->query( "DELETE FROM ezproductcollection_item where productcollection_id='$productCollectionID'" );
$db->query( "DELETE FROM ezorder_status_history WHERE order_id=$orderNr" );
Expand Down