Error- no such module 'DangerSwiftCoverage'

[doronkatz]

So i have an SPM project, in Swift 5.1. My Dangerfile.swift file has:

import Danger
import DangerSwiftCoverage

let danger = Danger()
Coverage.spmCoverage(minimumCoverage: 50)

I imported in my Package.swift as per instructions.

When I run the following, I get an error:

$ swift run danger-swift local
/var/folders/68/946ywfgx3jq3bwhy02std9tc0000gn/T/_tmp_dangerfile.swift:9:8: error: no such module 'DangerSwiftCoverage'
import DangerSwiftCoverage
       ^

ERROR: Dangerfile eval failed at Dangerfile.swift
ERROR: Could not get the results JSON file at /var/folders/68/946ywfgx3jq3bwhy02std9tc0000gn/T/danger-response.json

Danger: ⅹ Failing the build, there is 1 fail.
## Failures
danger-swift` failed.
## Markdowns
### Log


```sh
/var/folders/68/946ywfgx3jq3bwhy02std9tc0000gn/T/_tmp_dangerfile.swift:9:8: error: no such module 'DangerSwiftCoverage'
import DangerSwiftCoverage
       ^
ERROR: Dangerfile eval failed at Dangerfile.swift
ERROR: Could not get the results JSON file at /var/folders/68/946ywfgx3jq3bwhy02std9tc0000gn/T/danger-response.json

[doronkatz]

I also have a DangerDependencies in Sources, with Fake.swift.

[f-meloni]

Can you please show me your Package.swift?

[doronkatz]

Certainly, It's: ``` // swift-tools-version:5.1 // The swift-tools-version declares the minimum version of Swift required to build this package. *import* PackageDescription *let* package = Package( name: "SwiftRecommendations", platforms: [ .iOS(.v13), .macOS(.v10_13), .tvOS(.v13) ], products: [ // Products define the executables and libraries produced by a package, and make them visible to other packages. .library( name: "SwiftRecommendations", targets: ["SwiftRecommendations"]) ], dependencies: [ .package(url: "https://github.com/apple/swift-log.git", from: "1.0.0"), .package(url: "https://github.com/f-meloni/danger-swift-coverage", from: "0.1.0") ], targets: [ // Targets are the basic building blocks of a package. A target can define a module or a test suite. // Targets can depend on other targets in this package, and on products in packages which this package depends on. .target( name: "SwiftRecommendations", dependencies: ["Logging"]), .testTarget( name: "SwiftRecommendationsTests", dependencies: ["SwiftRecommendations", "Logging"]) ] ) ```

…

On Tue, Nov 26, 2019, at 12:01 PM, Franco Meloni wrote: Can you please show me your `Package.swift`? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19?email_source=notifications&email_token=AACUJJ4LJBRIITWDLW7ARX3QVV577A5CNFSM4JR354D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFHIOTA#issuecomment-558794572>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACUJJ7RHPBDHWCQLF4YPM3QVV577ANCNFSM4JR354DQ>.

--- EMAIL: [email protected] OFFICE: +1 (408) 454 8449 <tel:+1%20(408)%20454%208449> CELL: (+1) 718 795 8873 <tel:(+1)%20718%20795%208873> WWW: _http://www.doronkatz.com _ Schedule time with me: https://doronkatz.youcanbook.me This email and any attachments are confidential and may be subject to copyright, legal or some other professional privilege. They are intended solely for the attention and use of the named addressee(s). They may only be copied, distributed or disclosed with the consent of the copyright owner. If you have received this email by mistake or by breach of the confidentiality clause, please notify the sender immediately by return email and delete or destroy all copies of the email. Any confidentiality, privilege or copyright is not waived or lost because this email has been sent to you by mistake. This email and any attachments are confidential and may be subject to copyright, legal or some other professional privilege. They are intended solely for the attention and use of the named addressee(s). They may only be copied, distributed or disclosed with the consent of the copyright owner. If you have received this email by mistake or by breach of the confidentiality clause, please notify the sender immediately by return email and delete or destroy all copies of the email. Any confidentiality, privilege or copyright is not waived or lost because this email has been sent to you by mistake.

[doronkatz]

Apologies, and also had it in the target list below. Sorry..

…

On Tue, Nov 26, 2019, at 12:30 PM, Doron Katz wrote: Certainly, It's: ``` // swift-tools-version:5.1 // The swift-tools-version declares the minimum version of Swift required to build this package. *import* PackageDescription *let* package = Package( name: "SwiftRecommendations", platforms: [ .iOS(.v13), .macOS(.v10_13), .tvOS(.v13) ], products: [ // Products define the executables and libraries produced by a package, and make them visible to other packages. .library( name: "SwiftRecommendations", targets: ["SwiftRecommendations"]) ], dependencies: [ .package(url: "https://github.com/apple/swift-log.git", from: "1.0.0"), .package(url: "https://github.com/f-meloni/danger-swift-coverage", from: "0.1.0") ], targets: [ // Targets are the basic building blocks of a package. A target can define a module or a test suite. // Targets can depend on other targets in this package, and on products in packages which this package depends on. .target( name: "SwiftRecommendations", dependencies: ["Logging"]), .testTarget( name: "SwiftRecommendationsTests", dependencies: ["SwiftRecommendations", "Logging"]) ] ) ``` On Tue, Nov 26, 2019, at 12:01 PM, Franco Meloni wrote: > Can you please show me your `Package.swift`? > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub <#19?email_source=notifications&email_token=AACUJJ4LJBRIITWDLW7ARX3QVV577A5CNFSM4JR354D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFHIOTA#issuecomment-558794572>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACUJJ7RHPBDHWCQLF4YPM3QVV577ANCNFSM4JR354DQ>. --- EMAIL: ***@***.*** OFFICE: +1 (408) 454 8449 <tel:+1%20(408)%20454%208449> CELL: (+1) 718 795 8873 <tel:(+1)%20718%20795%208873> WWW: _http://www.doronkatz.com _ Schedule time with me: https://doronkatz.youcanbook.me This email and any attachments are confidential and may be subject to copyright, legal or some other professional privilege. They are intended solely for the attention and use of the named addressee(s). They may only be copied, distributed or disclosed with the consent of the copyright owner. If you have received this email by mistake or by breach of the confidentiality clause, please notify the sender immediately by return email and delete or destroy all copies of the email. Any confidentiality, privilege or copyright is not waived or lost because this email has been sent to you by mistake.

--- EMAIL: [email protected] OFFICE: +1 (408) 454 8449 <tel:+1%20(408)%20454%208449> CELL: (+1) 718 795 8873 <tel:(+1)%20718%20795%208873> WWW: _http://www.doronkatz.com _ Schedule time with me: https://doronkatz.youcanbook.me This email and any attachments are confidential and may be subject to copyright, legal or some other professional privilege. They are intended solely for the attention and use of the named addressee(s). They may only be copied, distributed or disclosed with the consent of the copyright owner. If you have received this email by mistake or by breach of the confidentiality clause, please notify the sender immediately by return email and delete or destroy all copies of the email. Any confidentiality, privilege or copyright is not waived or lost because this email has been sent to you by mistake. This email and any attachments are confidential and may be subject to copyright, legal or some other professional privilege. They are intended solely for the attention and use of the named addressee(s). They may only be copied, distributed or disclosed with the consent of the copyright owner. If you have received this email by mistake or by breach of the confidentiality clause, please notify the sender immediately by return email and delete or destroy all copies of the email. Any confidentiality, privilege or copyright is not waived or lost because this email has been sent to you by mistake.

[f-meloni]

If you change it like this it should work

Package(
    name: "SwiftRecommendations",
    platforms: [
        .iOS(.v13),
        .macOS(.v10_13),
        .tvOS(.v13)
    ],
    products: [
        // Products define the executables and libraries produced by a package, and make them visible to other packages.
        .library(
            name: "SwiftRecommendations",
            targets: ["SwiftRecommendations"]),
        .library(name: "DangerDeps", type: .dynamic, targets: ["DangerDependencies"])
    ],
    dependencies: [
        .package(url: "https://github.com/apple/swift-log.git",
                 from: "1.0.0"),
        .package(url: "https://github.com/f-meloni/danger-swift-coverage",
                 from: "0.1.0")
    ],
    targets: [
        // Targets are the basic building blocks of a package. A target can define a module or a test suite.
        
        // Targets can depend on other targets in this package, and on products in packages which this package depends on.
        .target(
            name: "SwiftRecommendations",
            dependencies: ["Logging"]),
        .testTarget(
            name: "SwiftRecommendationsTests",
            dependencies: ["SwiftRecommendations", "Logging"]),
        .target(name: "DangerDependencies", dependencies: ["DangerSwiftCoverage"])
    ]
)

[doronkatz]

Thanks,

So then I get:

swift run danger-swift local     12:42:17 


Danger: ⅹ Failing the build, there is 1 fail.
## Failures
Failed to get the coverage - Error: The folder “codecov” doesn’t exist.

Am i meant to create a codecov folder as well?

[f-meloni]

are you using Xcode 11.2.1? in that case this plugin doesn't work with it yet #18

[doronkatz]

Oh yes I am.. I see... Thanks ill hold off for that ticket to be resolved. Thanks !

[f-meloni]

Looking at your initial message you are using SPM, then #18 shouldn't affect you.
You should simply be able to run swift test --enable-code-coverage=true and then swift run danger-swift local should just work, unless there was a change on the SPM format as well

[doronkatz]

Ah that's it! I had to run swift test first. Sorry I ran swift build instead first... OK now it works: ``` Danger: ✓ passed review, received no feedback. ## Markdowns | File | Coverage || | --- | --- | --- | Sources/SwiftRecommendations/Models/ContentItem.swift | 9.259259% | ⚠️ Sources/SwiftRecommendations/Models/Paginator.swift | 0.0% | ⚠️ Sources/SwiftRecommendations/Models/Token.swift | 50.0% | ⚠️ Sources/SwiftRecommendations/Services/APIService.swift | 72.18045% | ✅ Tests/SwiftRecommendationsTests/SwiftRecommendationsTests.swift | 88.39779% | ✅ ``` Thanks!

…

On Tue, Nov 26, 2019, at 1:14 PM, Franco Meloni wrote: Looking at your initial message you are using SPM, then #18 <#18> *shouldn't* affect you. You should simply be able to run `swift test --enable-code-coverage=true` and then `sAh` should just work, unless there was a change on the SPM format as well — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19?email_source=notifications&email_token=AACUJJ7A2E3LIF5QHKGFAJTQVWGS5A5CNFSM4JR354D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFHOTGQ#issuecomment-558819738>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACUJJ6EPQEARNROVJMJD3TQVWGS5ANCNFSM4JR354DQ>.

--- EMAIL: [email protected] OFFICE: +1 (408) 454 8449 <tel:+1%20(408)%20454%208449> CELL: (+1) 718 795 8873 <tel:(+1)%20718%20795%208873> WWW: _http://www.doronkatz.com _ Schedule time with me: https://doronkatz.youcanbook.me This email and any attachments are confidential and may be subject to copyright, legal or some other professional privilege. They are intended solely for the attention and use of the named addressee(s). They may only be copied, distributed or disclosed with the consent of the copyright owner. If you have received this email by mistake or by breach of the confidentiality clause, please notify the sender immediately by return email and delete or destroy all copies of the email. Any confidentiality, privilege or copyright is not waived or lost because this email has been sent to you by mistake. This email and any attachments are confidential and may be subject to copyright, legal or some other professional privilege. They are intended solely for the attention and use of the named addressee(s). They may only be copied, distributed or disclosed with the consent of the copyright owner. If you have received this email by mistake or by breach of the confidentiality clause, please notify the sender immediately by return email and delete or destroy all copies of the email. Any confidentiality, privilege or copyright is not waived or lost because this email has been sent to you by mistake.

[f-meloni]

No problem! closing, given is solved :)