Update README based on errors found on working with Xcode 11.4.x+/Swift 5.2 and CI #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 0874c02 |
f-meloni
reviewed
Jun 2, 2020
| ... | ||
| ], | ||
| targets: [ | ||
| .target(name: "DangerDependencies", dependencies: ["Danger", "DangerXCodeSummary"]), // dev | ||
| .target(name: "DangerDependencies", dependencies: ["danger-swift", "DangerXCodeSummary"]) // dev |
There was a problem hiding this comment.
I think that could potentially remove some optimisations SPM would do here, given you only need the Danger library as dependency not the whole danger-swift, you don't need to build it all, then I would probably remove all the name: " change, at least for the danger-swift part.
| @@ -65,7 +72,12 @@ DangerXCodeSummary can be used with SPM (this repo uses it on the Linux CI), but | |||
| To generate the report run: | |||
|
|
|||
| ```bash | |||
| swift test | XCPRETTY_JSON_FILE_OUTPUT=result.json xcpretty -f `xcpretty-json-formatter` | |||
| swift test 2>&1 | XCPRETTY_JSON_FILE_OUTPUT=xcpretty_xcode_summary.json xcpretty -f `xcpretty-json-formatter` | |||
|
|
||
| [...] | ||
|
|
||
| swift run danger-swift ci --fail-on-errors=true |
There was a problem hiding this comment.
The correct call should be
swift run danger-swift ci --failOnErrors
Also I'm not sure everyone wants that behaviour, it depends if you want or not your CI to continue after danger runs, Danger already updates the state of the PR, then it really depends on your workflow if it should or not fail the build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the comments in this test PR ( #20 ), I was not seeing the errors being recorded in Xcode Summary as expected nor the build to fail if a unit test failed (all output, errors included, needed to be redirected and piped through xcpretty).
Also, I had some issues installing Danger and Danger Plugins such as this one without adapting the Package.swift as SwiftPM was suggesting (see list of changes).