Add 2 new properties to provide warnings and error counts based on result filter #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sult filter The computed properties use the same logic that is used in the report function.
arpitdunzo
reviewed
Nov 10, 2021
| @@ -40,6 +40,11 @@ public final class XCodeSummary { | |||
| public var warningsCount: Int { | |||
| return warnings.count | |||
| } | |||
|
|
|||
| /// Numbber of warnings filtered using the provided result filter | |||
arpitdunzo
reviewed
Nov 10, 2021
| @@ -40,6 +40,11 @@ public final class XCodeSummary { | |||
| public var warningsCount: Int { | |||
| return warnings.count | |||
| } | |||
|
|
|||
| /// Numbber of warnings filtered using the provided result filter | |||
| public var filteredWariningCount: Int { | |||
|
@f-meloni let me if this approach works |
f-meloni
approved these changes
Nov 12, 2021
|
@f-meloni only you have write access so i guess you'll have to merge PR. I added test to check but i'm unable to run the test target. Getting the following error |
|
Hey @theScud I dropped the ball with this, sorry I completely missed your message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The computed properties use the same logic that is used in the report function.
Addresses Issue : #23
Note: this preliminary PR just to discuss approach i'll be adding test and docs after approach has been approved