Optim : Loop can be replace with 'in_array()'

f00b4r · Feb 13, 2023 · 5aff87a · 5aff87a
1 parent eedc2a5
commit 5aff87a
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/nusoap.php b/src/nusoap.php
@@ -5405,11 +5405,10 @@ function getOperationData($operation, $bindingType = 'soap')
             if ($portData['bindingType'] == $bindingType) {
                 // get binding
                 //foreach($this->bindings[ $portData['binding'] ]['operations'] as $bOperation => $opData) {
-                foreach (array_keys($this->bindings[$portData['binding']]['operations']) as $bOperation) {
-                    // note that we could/should also check the namespace here
-                    if ($operation == $bOperation) {
-                      return $this->bindings[$portData['binding']]['operations'][$operation];
-                    }
+                // note that we could/should also check the namespace here
+                if (in_array ($operation, array_keys ($this->bindings[$portData['binding']]['operations'])))
+                {
+                    return $this->bindings[$portData['binding']]['operations'][$operation];
                 }
             }
         }