Dump "camera" info should dump information about all options #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1809 +/- ##
==========================================
- Coverage 95.68% 95.67% -0.02%
==========================================
Files 123 123
Lines 9754 9776 +22
==========================================
+ Hits 9333 9353 +20
- Misses 421 423 +2 ☔ View full report in Codecov by Sentry. |
samoncrief
force-pushed
the
print-info-console
branch
from
b70e07a to
e5a7452
Compare
mwestphal
requested changes
Dec 21, 2024
| @@ -46,6 +47,9 @@ class scene_impl : public scene | |||
| */ | |||
| void SetInteractor(interactor_impl* interactor); | |||
|
|
|||
| // Display available cameras in the log | |||
There was a problem hiding this comment.
please use doxygen style doc
/**
*
*/
| } | ||
| log::print(level, ""); | ||
| log::print(level, this->Internals->MetaImporter->GetOutputsDescription(), "\n"); | ||
| } |
There was a problem hiding this comment.
this code is a duplicate of DisplayImporterDescription, please factorize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.