Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record: Fix an issue when quitting while recording #1827

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Dec 22, 2024

Fix #1793

This does not fix #226

This is not testable nor coverable.

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.64%. Comparing base (d454e31) to head (575c53f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...t/private/module/vtkF3DInteractorEventRecorder.cxx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1827      +/-   ##
==========================================
- Coverage   95.68%   95.64%   -0.04%     
==========================================
  Files         123      123              
  Lines        9756     9760       +4     
==========================================
  Hits         9335     9335              
- Misses        421      425       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal merged commit 6d84296 into f3d-app:master Dec 22, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interaction-test-record prevent application from quitting
2 participants