Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libf3d: Improve API for [[nodiscard]] and missing this* return #1830

Merged
merged 5 commits into from
Dec 26, 2024

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Dec 23, 2024

@mwestphal mwestphal self-assigned this Dec 23, 2024
Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.64%. Comparing base (9852dab) to head (74cee5b).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1830   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files         123      123           
  Lines        9763     9764    +1     
=======================================
+ Hits         9338     9339    +1     
  Misses        425      425           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal changed the title libf3d: Add [[nodiscard]] wherever it makes sense libf3d: Improve API for C++17 support Dec 23, 2024
 - Adding [[nodiscard]] on all method where it makes sense
 - Updating test to use std::ignore when needed
This reverts commit 9fd5c41.
@mwestphal mwestphal changed the title libf3d: Improve API for C++17 support libf3d: Improve API for [[nodiscard]] and missing this* return Dec 23, 2024
@mwestphal mwestphal merged commit fda96ea into f3d-app:master Dec 26, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants