- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework animation suport #836
Conversation
b893a8a
to
bbf2bde
Compare
bad4631
to
0c29fe4
Compare
0c29fe4
to
edaff12
Compare
- Rely on real elapsed time instead of timestep to animate - Add an animation speed factor option to slow, speed and invert time - Fix multiple issues related to time and improve internal doc - update tests accordingly - Add doc for --animation-speed-factor
edaff12
to
ce0af0a
Compare
92c3161
to
576324a
Compare
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
==========================================
- Coverage 96.24% 96.14% -0.11%
==========================================
Files 111 111
Lines 6265 6333 +68
==========================================
+ Hits 6030 6089 +59
- Misses 235 244 +9
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dd421d1
to
8f64d5c
Compare
a21b687
to
66f14d0
Compare
@snoyer please review |
0e60220
to
5ecd878
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea how any of this is expected to work so I did a pass just looking at the diff
## Rework animation suport - Rely on real elapsed time instead of timestep to animate - Store animationManager in loader instead of interactor - Add an --animation-speed-factor option to slow, speed and invert time\ - Add an --animation-time option to set an animation time to load - Add an --animation-frame-rate option to control animation frame rate - Fix multiple issues related to time and improve internal doc - update tests accordingly - Add doc for options and animations
## Rework animation suport - Rely on real elapsed time instead of timestep to animate - Store animationManager in loader instead of interactor - Add an --animation-speed-factor option to slow, speed and invert time\ - Add an --animation-time option to set an animation time to load - Add an --animation-frame-rate option to control animation frame rate - Fix multiple issues related to time and improve internal doc - update tests accordingly - Add doc for options and animations
Rework animation suport