Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework animation suport #836

Merged
merged 22 commits into from
Jun 7, 2023
Merged

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Jun 1, 2023

Rework animation suport

  • Rely on real elapsed time instead of timestep to animate
  • Store animationManager in loader instead of interactor
  • Add an --animation-speed-factor option to slow, speed and invert time\
  • Add an --animation-time option to set an animation time to load
  • Add an --animation-frame-rate option to control animation frame rate
  • Fix multiple issues related to time and improve internal doc
  • update tests accordingly
  • Add doc for options and animations

@mwestphal mwestphal marked this pull request as ready for review June 3, 2023 13:49
@mwestphal mwestphal force-pushed the timerange_support branch from b893a8a to bbf2bde Compare June 3, 2023 13:49
@mwestphal mwestphal force-pushed the timerange_support branch 2 times, most recently from bad4631 to 0c29fe4 Compare June 4, 2023 07:56
@mwestphal mwestphal changed the title Draft time range support Rework animation suport Jun 4, 2023
@mwestphal mwestphal force-pushed the timerange_support branch from 0c29fe4 to edaff12 Compare June 4, 2023 08:13

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- Rely on real elapsed time instead of timestep to animate
- Add an animation speed factor option to slow, speed and invert time
- Fix multiple issues related to time and improve internal doc
- update tests accordingly
- Add doc for --animation-speed-factor
@mwestphal mwestphal force-pushed the timerange_support branch from edaff12 to ce0af0a Compare June 4, 2023 08:54
@mwestphal mwestphal force-pushed the timerange_support branch from 92c3161 to 576324a Compare June 4, 2023 11:51
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #836 (1383448) into master (b8c4ad9) will decrease coverage by 0.11%.
The diff coverage is 95.79%.

@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
- Coverage   96.24%   96.14%   -0.11%     
==========================================
  Files         111      111              
  Lines        6265     6333      +68     
==========================================
+ Hits         6030     6089      +59     
- Misses        235      244       +9     
Impacted Files Coverage Δ
...rary/VTKExtensions/Readers/vtkF3DGenericImporter.h 100.00% <ø> (ø)
library/private/animationManager.h 100.00% <ø> (ø)
plugins/assimp/module/vtkF3DAssimpImporter.h 100.00% <ø> (ø)
plugins/native/gltf.inl 100.00% <ø> (ø)
...ry/VTKExtensions/Readers/vtkF3DGenericImporter.cxx 96.66% <85.71%> (-1.02%) ⬇️
plugins/assimp/module/vtkF3DAssimpImporter.cxx 89.29% <85.71%> (-0.25%) ⬇️
application/F3DOptionsParser.cxx 98.38% <100.00%> (+0.01%) ⬆️
library/src/animationManager.cxx 100.00% <100.00%> (ø)
library/src/interactor_impl.cxx 100.00% <100.00%> (ø)
library/src/loader_impl.cxx 100.00% <100.00%> (ø)
... and 1 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mwestphal mwestphal force-pushed the timerange_support branch from dd421d1 to 8f64d5c Compare June 4, 2023 15:26
@mwestphal mwestphal force-pushed the timerange_support branch from a21b687 to 66f14d0 Compare June 4, 2023 17:11
@mwestphal mwestphal requested a review from Meakk June 4, 2023 17:41
@mwestphal
Copy link
Contributor Author

@snoyer please review

@mwestphal mwestphal force-pushed the timerange_support branch from 0e60220 to 5ecd878 Compare June 4, 2023 17:49
Copy link
Contributor

@snoyer snoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how any of this is expected to work so I did a pass just looking at the diff

library/src/animationManager.cxx Outdated Show resolved Hide resolved
library/src/animationManager.cxx Outdated Show resolved Hide resolved
doc/libf3d/OPTIONS.md Show resolved Hide resolved
doc/libf3d/OPTIONS.md Show resolved Hide resolved
plugins/assimp/module/vtkF3DAssimpImporter.cxx Outdated Show resolved Hide resolved
plugins/assimp/module/vtkF3DAssimpImporter.cxx Outdated Show resolved Hide resolved
@mwestphal mwestphal requested review from snoyer and Meakk June 6, 2023 06:01
@mwestphal mwestphal requested a review from Meakk June 6, 2023 16:29
@mwestphal mwestphal merged commit 6afde75 into f3d-app:master Jun 7, 2023
mwestphal added a commit that referenced this pull request Feb 10, 2024
## Rework animation suport

- Rely on real elapsed time instead of timestep to animate
- Store animationManager in loader instead of interactor
- Add an --animation-speed-factor option to slow, speed and invert time\
- Add an --animation-time option to set an animation time to load
- Add an --animation-frame-rate option to control animation frame rate
- Fix multiple issues related to time and improve internal doc 
- update tests accordingly
- Add doc for options and animations
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
## Rework animation suport

- Rely on real elapsed time instead of timestep to animate
- Store animationManager in loader instead of interactor
- Add an --animation-speed-factor option to slow, speed and invert time\
- Add an --animation-time option to set an animation time to load
- Add an --animation-frame-rate option to control animation frame rate
- Fix multiple issues related to time and improve internal doc 
- update tests accordingly
- Add doc for options and animations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants