Merge pull request #809 from fabian-hiller/feat-nested-variants

Improve performance and issues for nested variants
fabian-hiller · Sep 1, 2024 · 0dfd1bd · 0dfd1bd
2 parents 5e1dcda + 139d865
commit 0dfd1bd
Show file tree

Hide file tree

Showing 12 changed files with 1,122 additions and 198 deletions.
diff --git a/library/CHANGELOG.md b/library/CHANGELOG.md
@@ -5,6 +5,7 @@ All notable changes to the library will be documented in this file.
 ## vX.X.X (Month DD, YYYY)
 
 - Change `reference` property of all action base types to be less strict (issue #799)
+- Change implementation of `variant` and `variantAsync` to improve performance and issues generation for nested variants with different discriminators (pull request #809)
 
 ## v0.40.0 (August 29, 2024)
 

diff --git a/library/src/schemas/variant/types.ts b/library/src/schemas/variant/types.ts
@@ -50,7 +50,7 @@ export interface VariantIssue extends BaseIssue<unknown> {
 /**
  * Variant option schema type.
  */
-interface VariantOptionSchema<TKey extends string>
+export interface VariantOptionSchema<TKey extends string>
   extends BaseSchema<unknown, unknown, VariantIssue | BaseIssue<unknown>> {
   readonly type: 'variant';
   readonly reference: typeof variant;
@@ -62,7 +62,7 @@ interface VariantOptionSchema<TKey extends string>
 /**
  * Variant option schema async type.
  */
-interface VariantOptionSchemaAsync<TKey extends string>
+export interface VariantOptionSchemaAsync<TKey extends string>
   extends BaseSchemaAsync<unknown, unknown, VariantIssue | BaseIssue<unknown>> {
   readonly type: 'variant';
   readonly reference: typeof variantAsync;

diff --git a/library/src/schemas/variant/utils/_discriminators/_discriminators.test.ts b/library/src/schemas/variant/utils/_discriminators/_discriminators.test.ts
diff --git a/library/src/schemas/variant/utils/_discriminators/_discriminators.ts b/library/src/schemas/variant/utils/_discriminators/_discriminators.ts
diff --git a/library/src/schemas/variant/utils/_discriminators/index.ts b/library/src/schemas/variant/utils/_discriminators/index.ts
diff --git a/library/src/schemas/variant/utils/index.ts b/library/src/schemas/variant/utils/index.ts