Merge pull request #732 from EltonLobo07/fix/fallbackAsync-async-arg

fix `fallbackAsync` for async arg & add relevant tests
fabian-hiller · Jul 21, 2024 · 7908989 · 7908989
2 parents 4381e20 + 659f687
commit 7908989
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/library/CHANGELOG.md b/library/CHANGELOG.md
@@ -7,6 +7,7 @@ All notable changes to the library will be documented in this file.
 - Add `base64` action to validate Base64 strings (pull request #644)
 - Refactor `HEXADECIMAL_REGEX` (pull request #666)
 - Change `EMOJI_REGEX` to be more accurate and strict (pull request #666)
+- Fix bug in `fallbackAsync` method for async schemas (pull request #732)
 
 ## v0.36.0 (July 05, 2024)
 

diff --git a/library/src/methods/fallback/fallbackAsync.test.ts b/library/src/methods/fallback/fallbackAsync.test.ts
@@ -1,15 +1,18 @@
 import { describe, expect, test } from 'vitest';
-import { transform } from '../../actions/index.ts';
+import { transformAsync } from '../../actions/index.ts';
 import { number } from '../../schemas/index.ts';
-import { pipe } from '../pipe/index.ts';
+import { pipeAsync } from '../pipe/index.ts';
 import {
   fallbackAsync,
   type SchemaWithFallbackAsync,
 } from './fallbackAsync.ts';
 
 describe('fallbackAsync', () => {
   describe('should return schema object', () => {
-    const schema = pipe(number(), transform(String));
+    const schema = pipeAsync(
+      number(),
+      transformAsync(async (input) => String(input))
+    );
     type Schema = typeof schema;
     const baseSchema: Omit<
       SchemaWithFallbackAsync<Schema, never>,
@@ -45,7 +48,10 @@ describe('fallbackAsync', () => {
   });
 
   const schema = fallbackAsync(
-    pipe(number(), transform(String)),
+    pipeAsync(
+      number(),
+      transformAsync(async (input) => String(input))
+    ),
     async () => '123'
   );
 

diff --git a/library/src/methods/fallback/fallbackAsync.ts b/library/src/methods/fallback/fallbackAsync.ts
@@ -79,7 +79,7 @@ export function fallbackAsync<
     fallback,
     async: true,
     async _run(dataset, config) {
-      schema._run(dataset, config);
+      await schema._run(dataset, config);
       return dataset.issues
         ? // @ts-expect-error
           { typed: true, value: await getFallback(this, dataset, config) }