improve minValue & maxValue actions and add missing test cases
#843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvement:
`maxValue` should add an issue when
`dataset.value` is `NaN`
Improvement:
`minValue` should add an issue when
`dataset.value` is `NaN`
commit: |
|
Thank you! I will try to review and merge it on the weekend. |
fabian-hiller
force-pushed
the
main
branch
2 times, most recently
from
7a97dd0 to
b5f7f4d
Compare
test three cases for every non-type:
- general
- false
- true
test three cases for every non-type:
- general
- false
- true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of the actions will add an issue when
dataset.valueisNaN.