This repository has been archived by the owner on May 29, 2024. It is now read-only.
refactor: uniformise and prepare authorization system for no login mode #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix public url request redirection (Closes #1225) - Remove unecessary layer with keycloak-react package (move code to launcher-app) - Fix bug where request query was removed in openshift redirect_uri - Fix bug where requert query was removed in cleanUrl (end of init) - Uniformise and refactor Authorization (prepare for #1254) - Remove hack and standardize AuthenticationError
Codecov Report
@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
+ Coverage 81.97% 82.02% +0.04%
==========================================
Files 50 51 +1
Lines 1182 1196 +14
Branches 121 118 -3
==========================================
+ Hits 969 981 +12
- Misses 178 181 +3
+ Partials 35 34 -1 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
+ Coverage 81.97% 82.02% +0.04%
==========================================
Files 50 51 +1
Lines 1182 1196 +14
Branches 121 118 -3
==========================================
+ Hits 969 981 +12
- Misses 178 181 +3
+ Partials 35 34 -1 |
ia3andy
changed the title
|
This PR was deployed with mocked data in the following URLs for your appreciation: |
edewit
approved these changes
Apr 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/launchprefix #1255)