Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Allow to provide additional fragment filename mappings #1382

Open
rhuss opened this issue Sep 14, 2018 · 5 comments
Open

Allow to provide additional fragment filename mappings #1382

rhuss opened this issue Sep 14, 2018 · 5 comments
Assignees
Labels
status/never-stale Pin this issue to get never marked as stale by stale-bot target/4.0 PR for targeted to 4.0.x
Milestone

Comments

@rhuss
Copy link
Contributor

rhuss commented Sep 14, 2018

Description

Currently, the mapping from filename suffixes to resource kinds is predefined within the plugin (now via an internal configuration implemented for #1372).

To be more future proof for new kinds it would be nice to allow the user to specify additional mappings.

This could be done in several ways:

  • Providing a single property pointing to a properties file holding the mapping (e.g. with suffix=kind properties. Maybe with a sensible default for the filename which, when it exists, is automatically picked up (like the fragments)
  • Allow a plugin configuration to specify the mapping in XML style.
@rhuss rhuss added the target/4.0 PR for targeted to 4.0.x label Sep 14, 2018
@lordofthejars lordofthejars added this to the Sprint 155 milestone Sep 16, 2018
@lordofthejars lordofthejars self-assigned this Sep 16, 2018
@lordofthejars
Copy link
Contributor

@rhuss

Maybe with a sensible default for the filename

Should be the default disk-based or classpath based? Not sure about the best usage for default.

If disk-based, which would be the best default folder location for a Maven plugin?

@rhuss
Copy link
Contributor Author

rhuss commented Sep 17, 2018

Maybe we could allow both:

  • Disk-based for a quick and explicit way to specify the mapping. As a default path we unfortunately currently can't use src/main/fabric8 as everything within this folder is considered to be reserved for profiles and fragments. But maybe we should also might reconsider this, too for 4.0. I have to revisit the current external configuration that we allow and the files involved to come to a more streamlined directory layout.
  • Classpath based for e.g more persistent extensions points. That's how we allow for custom enricher and generator, too. The dependencies should be added on the plugin level. Here I would put it again below META-INF/fabric8

@lordofthejars
Copy link
Contributor

Ok then for now just classpath in META-INF/fabric8.

Now checking how to make to read custom ones from Maven configuration tag

lordofthejars added a commit to lordofthejars/fabric8-maven-plugin that referenced this issue Sep 18, 2018
lordofthejars added a commit to lordofthejars/fabric8-maven-plugin that referenced this issue Oct 1, 2018
rhuss pushed a commit to lordofthejars/fabric8-maven-plugin that referenced this issue Oct 2, 2018
rhuss pushed a commit to lordofthejars/fabric8-maven-plugin that referenced this issue Oct 2, 2018
lordofthejars added a commit to lordofthejars/fabric8-maven-plugin that referenced this issue Oct 2, 2018
lordofthejars added a commit to lordofthejars/fabric8-maven-plugin that referenced this issue Oct 2, 2018
@stale
Copy link

stale bot commented Dec 17, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Dec 17, 2018
@rohanKanojia rohanKanojia removed the status/stale Issue/PR considered to be stale label Dec 17, 2018
lordofthejars added a commit to lordofthejars/fabric8-maven-plugin that referenced this issue Jan 17, 2019
@stale
Copy link

stale bot commented Mar 17, 2019

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Mar 17, 2019
@rohanKanojia rohanKanojia added status/never-stale Pin this issue to get never marked as stale by stale-bot and removed status/stale Issue/PR considered to be stale labels Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/never-stale Pin this issue to get never marked as stale by stale-bot target/4.0 PR for targeted to 4.0.x
Projects
None yet
Development

No branches or pull requests

3 participants