Files with spaces in their name are not parsed correctly

[benmccormick]

When seeing file paths that have a space in them (yes clearly not ideal), fpp cuts off early or starts partway through

This is with fpp version 0.5.7.

This image also shows the hyphenated extensions issue from #144

[pcottle]

Can you try using 0.6.0 by any chance? We added filesystem validation:
https://github.com/facebook/PathPicker/releases/tag/0.6.0

So we can actually parse files with spaces in them now :) You should be able to upgrade via brew since thats the latest version:
https://github.com/Homebrew/homebrew/blob/master/Library/Formula/fpp.rb

Or just clone the repo and do brew install ./fpp.rb

[pcottle]

The hyphens stuff will be easy to add, thats just a regex change.

closing this out since im pretty sure we have files with spaces working, but reopen if you can repro on 0.6

[benmccormick]

Ah, I checked to see if there was a newer version but forgot to call brew update first.

Unfortunately the file system validation seems to remove the false positives but not actually correctly identify that the file with a space in it exists.

[pcottle]

Are you talking about the Package Control.user-ca-bundle files? In order for those to parse, we need both spaces //and// hyphen support, and I just landed the hyphen support in that other task. so try installing from master! should work then. probably will update homebrew by EOW

[benmccormick]

None of the files above were selectable except the bottom one. Does the hyphen issue effect hyphens in folders as well as extensions? If not I'd expect sublime/user-packages/Package Control.cache to work.

Update: Confirmed that this issue persists on master.

Sorry for the pain. Sublime configuration files are admittedly an awful hodge-podge of edge cases for this type of thing.

[pcottle]

Ah dang ok I'll take another look at this then

[pcottle]

Ah this was easy to fix -- just needed to allow extensions to have hyphens in the regex that allows spaces :O woof. #149 should go in clean and then we are good!

[benmccormick]

Confirmed that this all looks good now on master. Thanks! I'm excited about this project and have been enjoying using it.

[pcottle]

Great to hear @benmccormick ! 😍 feel free to drop by and open issues in the future for other bugs / improvements