X Mode (rebased) #137
X Mode (rebased) #137
Conversation
Control, still broken
|
I think there's a very small bug where if you're in X mode and you enter command mode, you'll be back in select mode when you are back on the main choose screen. Also I think the color of the text is white only because we are printing the scrollbar chrome right before, so the default color is set. It's not necessary but would be very good to use the color printer to affirmatively default to the default foreground color. (whew). I could do that in my cleanup PR #139 if @pcottle merges this first. |
yeah I could see that happening -- we probably need to track some kind of
yeah do you mind doing this @xavierbeynon and possibly adding a test for X-mode as well? It should be easy if you just provide |
| @@ -370,6 +381,8 @@ def processInput(self, key): | |||
| # before exiting the program | |||
| self.getFilesToUse() | |||
| self.cursesAPI.exit() | |||
| elif self.mode == X_MODE and key in lbls: | |||
There was a problem hiding this comment.
this might prone to breakage in the future since we might add keys above this statement that are in lbls and forget about X_MODE. i wonder if we could instead refactor some of this...
|
Sorry for being late guys - I'm between situations right now. I could probably write a test this weekend and refactor the keys thing. I don't really want to do anything with color printer since I don't know what that is. |
its cool! let me see if i can merge this all in |
|
Alright sweet! Thanks @xavierbeynon for the PR, rebasing was quite trivial (just a merge conflict in an expected test output file). Now that I'm playing around with this locally it actually is quite fun / useful :) we should try to figure out how to turn off the cursor in x mode -- one more thing to fix |
|
Fixed! Alright I think this is all wrapped up now, thanks again 🎉 👏 this should make it into the 0.6.1 release |
Rebased previous x mode + nits + small test updates.