Skip to content

Commit

Permalink
prelude/python: Propagate versioned deps in cxx_python_extension
Browse files Browse the repository at this point in the history
Reviewed By: aleivag

Differential Revision: D68209224

fbshipit-source-id: 7e8732edcf30cc340c751a4af5c4f87f22608967
  • Loading branch information
zsol authored and facebook-github-bot committed Jan 20, 2025
1 parent 26e86be commit 0119f68
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion python/cxx_python_extension.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ load(
)
load(":python.bzl", "PythonLibraryInfo")
load(":python_library.bzl", "create_python_library_info", "dest_prefix", "gather_dep_libraries", "qualify_srcs")
load(":versions.bzl", "gather_versioned_dependencies")

# This extension is basically cxx_library, plus base_module.
# So we augment with default attributes so it has everything cxx_library has, and then call cxx_library_parameterized and work from that.
Expand Down Expand Up @@ -271,7 +272,8 @@ def cxx_python_extension_impl(ctx: AnalysisContext) -> list[Provider]:
get_platform_attr(python_platform, cxx_toolchain, ctx.attrs.platform_deps),
)

deps, shared_deps = gather_dep_libraries(raw_deps)
deps, shared_deps = gather_dep_libraries(raw_deps, resolve_versioned_deps = False)
providers.append(gather_versioned_dependencies(raw_deps))
library_info = create_python_library_info(
ctx.actions,
ctx.label,
Expand Down

0 comments on commit 0119f68

Please sign in to comment.