Require TARGET_ELECTRON to be 'true' to be enabled

facebook · Jul 5, 2019 · 75d6580 · 75d6580
1 parent c020acb
commit 75d6580
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/packages/react-scripts/config/webpack.config.js b/packages/react-scripts/config/webpack.config.js
@@ -663,20 +663,22 @@ module.exports = function(webpackEnv) {
     ].filter(Boolean),
     // Some libraries import Node modules but don't use them in the browser.
     // Tell Webpack to provide empty mocks for them so importing them works.
-    node: process.env.TARGET_ELECTRON
-      ? undefined
-      : {
-          module: 'empty',
-          dgram: 'empty',
-          dns: 'mock',
-          fs: 'empty',
-          http2: 'empty',
-          net: 'empty',
-          tls: 'empty',
-          child_process: 'empty',
-        },
+    node:
+      process.env.TARGET_ELECTRON === 'true'
+        ? undefined
+        : {
+            module: 'empty',
+            dgram: 'empty',
+            dns: 'mock',
+            fs: 'empty',
+            http2: 'empty',
+            net: 'empty',
+            tls: 'empty',
+            child_process: 'empty',
+          },
     // Support electron-renderer target via environmental flag, default to web
-    target: process.env.TARGET_ELECTRON ? 'electron-renderer' : 'web',
+    target:
+      process.env.TARGET_ELECTRON === 'true' ? 'electron-renderer' : 'web',
     // Turn off performance processing because we utilize
     // our own hints via the FileSizeReporter
     performance: false,