Emoji after build

[igrek8]

Not sure if this relates to emojione devs, but

We are using emojione lib to replace unicode emoji with svg/png images.

We ran into the problem when we run npm run build.
after the build, emojione fails to match emoji unicodes and stops working completely.

"☺️" OK both dev & prod environments
"😀" FAIL in prod env but OK in dev

May that be a problem due extreme uglifying or anything else I am missing?

Thanks in advance.

PS: using latest version of create react app and emojione. We

[igrek8]

I will create repo to reproduce

[igrek8]

Here we go https://github.com/crabicode/create-react-app-emoji

OK : npm start

FAIL : npm run build && serve -s build

[igrek8]

Will do diff soon,

but for now I have to download the emojione.min.js to the public/static and include script in index.html

branch to fix

[igrek8]

production -> "🕹�": "1f579
development -> "🕹️":"1f579"

Seems like some bits got missed... any ideas?

Please see diff image

[gaearon]

Tagging as needing investigating by a motivated contributor.

[viankakrisna]

seen a similar issue in this iamcal/js-emoji#46 it's related to UglifyJS. The solution for that issue is to add --ascii-only option in webpack's uglifyjs plugin. Maybe it would also fix this.

[BrodaNoel]

@viankakrisna will you send a PR for that?

[tbillington]

@viankakrisna I also have an issue related to regex which I feel is caused by the uglifier. To get around I need to pass extra build args like --ascii-only. It's something that's only possible by ejecting.

[gaearon]

@tbillington It's also possible by sending a PR that we can merge 😉

[gaearon]

Fixed by #2596.

[gaearon]

Fixed in 1.0.8. Please verify.
https://github.com/facebookincubator/create-react-app/releases/tag/v1.0.8

[igrek8]

@gaearon, Fixed & working like a charm. Thank you!

[hyperknot]

Just to report back about this behaviour, our build grew from 530 KB to 539 KB because of this change. There is no way 9 KB worth of emoji or regex in our code. Maybe it's worth looking into a bit "softer" choice as growing 9 KB simply because of this emoji very much edge case seems like a waste of bandwidth.

[hyperknot]

OK, just did an a prettier version of both with and without ascii switch:

every occurence of ’ is changed to \u2019.
｜ -> \uff5c
“ and ’ are \u201c and \u2018

So I'd say that this option is quite buggy right now and is changing a lot of unneeded characters. Have a look at real world results on your web apps to see how much it affects you. In my case it's 9 KB of useless escaping, so I'll keep this off.

[Timer]

@hyperknot can you please open a new issue with the contents of your last two messages? This seems pretty problematic!
It's pretty hard to track here.

[hyperknot]

#2706

[Timer]

Thanks!