-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turn on ascii_only for issue with emoji and regex #2596
Conversation
Do we need to report a bug to Uglify? |
The question is why did they have that option in the first place and not turned on by default? I'll try to dig more on that. |
mishoo/UglifyJS#171 I think they do that because it affects bundle size. |
it also suggests that |
If we change it to remove dash does it work? Then I'd prefer to do that. |
it doesn't work when I remove the dash |
Thanks! |
Fixing #2488
Verified the changes by cloning https://github.com/crabicode/create-react-app-emoji and manually editing react-scripts/config/webpack.config.prod.js
Before:
After: