-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm start does not detect modifications in src/*/node_modules #3223
Milestone
Comments
We'll need someone to take over #2760 and champion it. 😄 |
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this issue
Aug 14, 2018
* Allow the dev server to watch for changes in src/node_modules * fix eslint error * fix broken regex * handle trailing slash edge case for file paths Closes facebook#2760 Fixes facebook#3223
LishuGupta652
pushed a commit
to LishuGupta652/create-react-app-1
that referenced
this issue
Oct 8, 2024
* Allow the dev server to watch for changes in src/node_modules * fix eslint error * fix broken regex * handle trailing slash edge case for file paths Closes facebook#2760 Fixes facebook#3223
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is this a bug report?
yes
Can you also reproduce the problem with npm 4.x?
yes
Which terms did you search for in User Guide?
node_modules, watch, absolute, relative, import, webpack
(also searched the change logs)
Environment
node -v
: v8.6.0npm -v
: 4.6.1 and 5.4.2yarn --version
(if you use Yarn): ---npm ls react-scripts
(if you haven’t ejected):└── [email protected]
(and I also tried [email protected] and [email protected] versions. There is no problem with 0.9.5)
Steps to Reproduce
console.log("Test.js imported");
import "Test.js";
Expected Behavior
at step 5. the project should recompile.
at step 6. the project should recompile with modified Test.js file.
This was the behavior with [email protected]. Downgrading fixes the issue.
Braking change was not reported on 0.9.5 -> 1.0.0.
Actual Behavior
at step 5. the project is not recompiled.
at step 6. the project is recompiled, but without Test.js modifications.
The project compiles without errors initially on npm start.
Reproducible Demo
create-react-app test
cd test
mkdir src/node_modules
echo "console.log("Test.js imported");" > src/node_modules/Test.js
mv src/index.js src/index.js.old
echo "import "Test.js";" > src/index.js
cat src/index.js.old >> src/index.js
rm src/index.js.old
npm start
(then make modifications on Test.js file)
The text was updated successfully, but these errors were encountered: