-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why ignoring casing on jsx-no-duplicate-props
?
#6956
Comments
I have also experienced this issue with Material-UI, although I'm more willing to blame their API for having confusable names. Case is ignored because for |
I think this should be fixed to use ignoreCase: false I'll be happy to submit a PR |
@rommguy feel free to start a PR. Sounds like a reasonable fix. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
@ianschmitz I opened a PR for this |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Still waiting for PR to be reviewed |
Is this a bug report?
No
Why ignoring casing on
jsx-no-duplicate-props
?When using Material-UI, you have components that can have different props with different casing as:
inputProps
andInputProps
,input
referring to the rendered DOM element andInput
relating to the React Component.Is there a specific reason on why CRA specifically ignores the casing instead of just going with the default which is "letting the casing be"? Could we change this rule as it wouldn't be a breaking change (I'm happy to make the PR)?
It's right on this line: https://github.com/facebook/create-react-app/blob/master/packages/eslint-config-react-app/index.js#L232
Thanks for your time,
Florian
The text was updated successfully, but these errors were encountered: