Remove unnecessary transform plugins for object spread to work

[valscion]

The babel-plugin-transform-object-rest-spread v6.19.0 update made the other two plugins unnecessary as it contains the fixes done in babel/babel#4755

https://github.com/babel/babel/blob/v6.19.0/CHANGELOG.md

Ref #904 (comment) and #927

Test plan

1. Use node v6.7.0

If you use nvm, this is how:

nvm install v6.7.0
nvm use v6.7.0

2. (Optional, I think) Use npm v2

npm install -g [email protected]

3. Modify App.test.js

Modify packages/react-scripts/template/src/App.test.js to look like this:

import React from 'react';
import ReactDOM from 'react-dom';
import App from './App';

it('renders without crashing', () => {
  const fn = ({ a, ...otherProps }) => otherProps;

  fn({ a: 1, b: 2 });

  console.log(fn({ a: 1, b: 2 }));

  const div = document.createElement('div');
  ReactDOM.render(<App />, div);
});

4. Install all the packages and run the test script

npm install
npm test

[gaearon]

What does the failure look like?

[gaearon]

cc @hzoo

[valscion]

What does the failure look like?

It looks like this:

FAIL  src/App.test.js
  ● Test suite failed to run

    /Users/vesa/code/muut/create-react-app/packages/react-scripts/template/src/App.test.js:6
      const fn = ({ a, ...otherProps }) => otherProps;
                       ^^^
    SyntaxError: Unexpected token ...

      at transformAndBuildScript (../node_modules/jest/node_modules/jest-cli/node_modules/jest-runtime/build/transform.js:284:10)
      at process._tickCallback (../../../internal/process/next_tick.js:103:7)

I'm not sure whether I have everything set up properly, but I've cleaned my node_modules multiple times across every package. I've followed the test plan many times, but still get the same error.

I added a commit valscion@9efbc7c that contains patch that should be legit, but crashes. This gist contains both the patch and the stacktrace: https://gist.github.com/valscion/25989e714380f2eabe52d170d6ca6f41

[hzoo]

babel-plugin-transform-class-properties

You should be updating object-rest-spread to v6.19.0 😄 that's all - it's currently "babel-plugin-transform-object-rest-spread": "6.16.0",

[valscion]

D'oh!

[valscion]

Ok, that should fix it, and now I don't get any errors anymore 😅 😅 😅 😅 Thanks @hzoo for pointing out my silly mistake! Funny how some things slip your eye so easily 😂

[hzoo]

I would add the 2 tests back as well

const { a, ...z } = obj;
const fn = ({ a, ...otherProps }) => otherProps;

[valscion]

I would add the 2 tests back as well

They haven't been there ever, I just used them to test the local changes. I think it's out of scope of this PR?

[gaearon]

LGTM