Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to svgr 6 #11780

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Upgrade to svgr 6 #11780

wants to merge 2 commits into from

Conversation

TrySound
Copy link

Ref https://github.com/gregberge/svgr/releases/tag/v6.0.0

This release bumped svgo internally which has a lot of fixes and less
dependencies.

@raix raix added this to the 5.1 milestone Dec 16, 2021
@@ -77,6 +76,7 @@
"workbox-webpack-plugin": "^6.4.1"
},
"devDependencies": {
"@svgr/webpack": "^6.1.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would still be a dependency of react-scripts, as we want it to install when users install react-scripts :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Put it there by inertia.

@stianjensen
Copy link

Nice! Looks like this needs a rebase on main (and I guess the commits here can be squashed).

Ref https://github.com/gregberge/svgr/releases/tag/v6.0.0

This release bumped svgo internally which has a lot of fixes and less
dependencies.
@agkhare
Copy link

agkhare commented May 6, 2022

@iansu We are waiting on this pull request to fix nth check vulnerability. Can you please help us with ETA on this one.?

@phnessu4
Copy link

It has been two months

@isqua
Copy link

isqua commented Sep 12, 2022

There are two PRs with update to newer version:

@rap2hpoutre
Copy link

Any news?

@HridoyHazard
Copy link

did it solved ??

@karlhorky
Copy link

@iansu @raix @mrmckeb anything missing from this PR? Would be great to install fewer dependencies...!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.