Fix issue #11930 where mini css extract plugin was updated to new version #11932
Conversation
|
Hi @daviesgeek! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
If I'm guessing they broke most their consumers with this change, as most people have cjs based webpack configs. |
|
Totally fair. Hope this gets resolved shortly since it's a massive impact for the community 😬 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| @@ -53,7 +53,7 @@ | |||
| "jest": "^27.4.3", | |||
| "jest-resolve": "^27.4.2", | |||
| "jest-watch-typeahead": "^1.0.0", | |||
| "mini-css-extract-plugin": "^2.4.5", | |||
| "mini-css-extract-plugin": "^2.5.0", | |||
There was a problem hiding this comment.
| "mini-css-extract-plugin": "^2.5.0", | |
| "mini-css-extract-plugin": "~2.4.7", |
There was a problem hiding this comment.
I think it's best to downgrade at the moment.
| @@ -16,7 +16,7 @@ const HtmlWebpackPlugin = require('html-webpack-plugin'); | |||
| const CaseSensitivePathsPlugin = require('case-sensitive-paths-webpack-plugin'); | |||
| const InlineChunkHtmlPlugin = require('react-dev-utils/InlineChunkHtmlPlugin'); | |||
| const TerserPlugin = require('terser-webpack-plugin'); | |||
| const MiniCssExtractPlugin = require('mini-css-extract-plugin'); | |||
| const { default: MiniCssExtractPlugin } = require('mini-css-extract-plugin'); | |||
There was a problem hiding this comment.
| const { default: MiniCssExtractPlugin } = require('mini-css-extract-plugin'); | |
| const MiniCssExtractPlugin = require('mini-css-extract-plugin'); |
Pretty straightforward: mini-css-extract-plugin was updated to 2.5.0 6 hours ago.
The reason for this change is explained in more detail here: webpack-contrib/mini-css-extract-plugin#896
This can break if you're not using yarn or some other way of pinning downstream dependencies.
Updated package.json to reflect version change. IMO this really should be a tilde
~instead of a caret^to avoid issues like this in the future.