-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README #1931
Updated README #1931
Conversation
README.md
Outdated
@@ -44,6 +44,8 @@ npm install -g create-react-app | |||
|
|||
**We strongly recommend to use Node >= 6 and npm >= 3 for faster installation speed and better disk usage.** You can use [nvm](https://github.com/creationix/nvm#usage) to easily switch Node versions between different projects. | |||
|
|||
**Note:** `nvm` does not support Windows (nvm issue [#284](https://github.com/creationix/nvm/issues/284)). See potential [alternatives](https://github.com/creationix/nvm#installation). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you embed this into previous sentence please? It's not super essential and I don't want to clobber up the page. For example "you can use nvm or alternatives to ..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if I remove the note on support for Windows users and rather update the link for nvm to direct users to the installation section of the docs which explains its compatibility. The reason I added the note is that the link to nvm takes the user to the usage section which doesn't quickly let the user see that they may not be able to use this for node management.
This is a fly-by but |
@Timer ya that might be something we can open up in a separate discussion to have more thoughts on the which tool is suggested by cra. Either tool unfortunately doesn't support Windows users and my opinion is that we should at least make that transparent if suggesting tools. |
Thanks! |
* adding comment on windows support of nvm * adding tree structure for intial project output * applying feedback from this thread create-react-app/pull/1931
* adding comment on windows support of nvm * adding tree structure for intial project output * applying feedback from this thread create-react-app/pull/1931
Updated README.md to note nvm support on windows and link to nvm docs on alternatives.
Added tree structure for better visual representation of the initial project output.