Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yarn.lock #2012

Closed
wants to merge 1 commit into from
Closed

Conversation

viankakrisna
Copy link
Contributor

I'm often cleaning my node_modules and reinstall it with yarn, and i notice that it always creates a new yarn.lock file. I think we should decide wether we want yarn.lock on the root of this project or not.

If we want to ignore it, i'll close this and do https://github.com/viankakrisna/create-react-app/tree/ignoreyarnlock instead.

@Timer
Copy link
Contributor

Timer commented Apr 22, 2017

This has been brought up before, I'm pretty sure the reasoning we haven't done it is that a yarn.lock isn't very portable cross-platform (because of optional deps, e.g. fsevents).

If we do anything, it'll probably be to ignore the lock files. It doesn't do us any good, we want to know when things break and they have no effect on the end-user when they install, so I think this will be a no go for now.

@viankakrisna
Copy link
Contributor Author

Ok then, opened another PR for adding it to .gitignore. I've searched the repo and haven't found anything mentioning yarn.lock on the root of this project. Is there any particular issue / pr that brought this up?

@trygveaa
Copy link
Contributor

This has been brought up before, I'm pretty sure the reasoning we haven't done it is that a yarn.lock isn't very portable cross-platform (because of optional deps, e.g. fsevents).

Seems like this has been fixed?
yarnpkg/yarn#2811

@gaearon
Copy link
Contributor

gaearon commented May 11, 2017

See my comment in #2014 (comment).
We intentionally don't want to either add or ignore it in this repo.

@gaearon gaearon closed this May 11, 2017
@viankakrisna viankakrisna deleted the addyarnlock branch June 1, 2017 11:48
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants