Unstage yarn.lock pre-commit #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdcrensh
force-pushed
the
git-rm-yarn-lock
branch
from
56ac56a to
b00c985
Compare
Since yarn.lock shouldn't be added to the repo, nor excluded via .gitignore, lets take advantage of lint-staged to remove any staged yarn.lock files before they can even be committed.
jdcrensh
force-pushed
the
git-rm-yarn-lock
branch
from
b00c985 to
3654c10
Compare
|
Why shouldn't it be checked in? The docs suggest otherwise https://yarnpkg.com/lang/en/docs/yarn-lock/. I should add that we specifically check this file in to get reproducible builds and would find it very awkward to work around this change. |
|
To be clear, this PR is relevant only to the create-react-app repo, where yarn.lock is neither committed nor gitignored. Apps using react-scripts would not be affected in any way. |
|
Ah, sorry, that makes much more sense. |
|
Seems very useful to me, thanks! |
JohnNilsson
referenced
this pull request
in JohnNilsson/create-react-app-typescript
Aug 9, 2017
Since yarn.lock shouldn't be added to the repo, nor excluded via .gitignore, lets take advantage of lint-staged to remove any staged yarn.lock files before they can even be committed.
zangrafx
added a commit
to absolvent/create-react-app
that referenced
this pull request
Aug 13, 2017
* commit 'bfaee410c502a95076a6bd89721c76ca08e15f7b': (39 commits) Publish Prepare for 1.0.11 release (facebook#2924) Update dev deps (facebook#2923) Update README.md Use env variable to disable source maps (facebook#2818) Make formatWebpackMessages return all messages (facebook#2834) Adjust the `checkIfOnline` check if in a corporate proxy environment (facebook#2884) Fix the order of arguments in spawned child proc (facebook#2913) Feature/webpack 3 4 (facebook#2875) Allow importing package.json (facebook#2468) Re-enable flowtype warning (facebook#2718) Format UglifyJs error (facebook#2650) Unstage yarn.lock pre-commit (facebook#2700) Update README.md Update README.md Add Electrode to alternatives (facebook#2728) Fix parsing HTML/JSX tags to real elements (facebook#2796) Update webpack version note (facebook#2798) Use modern syntax feature (facebook#2873) Allow use of scoped packages with a pinned version (facebook#2853) ... # Conflicts: # packages/react-scripts/config/webpack.config.dev.js # packages/react-scripts/config/webpack.config.prod.js # packages/react-scripts/package.json
JohnNilsson
referenced
this pull request
in JohnNilsson/create-react-app-typescript
Sep 9, 2017
Since yarn.lock shouldn't be added to the repo, nor excluded via .gitignore, lets take advantage of lint-staged to remove any staged yarn.lock files before they can even be committed.
kasperpeulen
pushed a commit
to kasperpeulen/create-react-app
that referenced
this pull request
Sep 24, 2017
Since yarn.lock shouldn't be added to the repo, nor excluded via .gitignore, lets take advantage of lint-staged to remove any staged yarn.lock files before they can even be committed.
swengorschewski
referenced
this pull request
in swengorschewski/cra-typescript-electron
Oct 16, 2017
Since yarn.lock shouldn't be added to the repo, nor excluded via .gitignore, lets take advantage of lint-staged to remove any staged yarn.lock files before they can even be committed.
|
What's going on there? Why not to just add the file into |
|
We don’t want repo developers each to get their own lockfile that would be respected by Yarn. Since then they wouldn’t get the freshest versions that match what users would get. |
|
@just-boris I wrote some of the reasons in https://github.com/luftywiranda13/remove-lockfiles#why 😊 |
|
In any case unstaging should be unnecessary now that we:
|
papermana
pushed a commit
to netguru/create-react-app
that referenced
this pull request
Jan 21, 2018
The create-react-app repo itself should not be using yarn.lock. See e.g. facebook#2700.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
yarn.lockshouldn't be added to the repo, nor excluded via.gitignore, lets take advantage oflint-stagedto unstage any stagedyarn.lockfiles before they can even be committed.