add link to deployment docs after build #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
viankakrisna
commented
Sep 10, 2017
viankakrisna
commented
This was referenced Sep 10, 2017
viankakrisna
force-pushed
the
deployment-instructions
branch
from
0abcb30 to
18855a4
Compare
|
Hello! I'm a bot that helps facilitate testing pull requests. Your pull request (commit 18855a4) has been released on npm for testing purposes. npm i [email protected]
# or
yarn add [email protected]
# or
create-react-app [email protected] folder/Note that the package has not been reviewed or vetted by the maintainers. Only install it at your own risk! Thanks for your contribution! |
|
Looks good, thanks! |
|
mm, actually i haven't tested this on my local after resolving on github 😅
I think the link for deployment should be on the bottom |
Merged
This was referenced Feb 2, 2018
Pavek
pushed a commit
to Pavek/create-react-app
that referenced
this pull request
Jul 10, 2018
* add link to deployment docs after build * Update printHostingInstructions.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.