added getProxy #3320
Merged
added getProxy #3320
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getProxy checks proxy settings from process.env.https_proxy or Yarn (NPM) config (.npmrc)
|
Can we change this to fall back to npm somehow? It feels a bit odd that we use Yarn for reading an npm file. |
default value for https-proxy is null, not undefined like in yarn
|
I've updated function to getting details from npm. |
|
Seems okay to me, thanks. |
Merged
|
This is out! Please let us know if something doesn’t quite work. |
This was referenced Feb 2, 2018
Pavek
pushed a commit
to Pavek/create-react-app
that referenced
this pull request
Jul 10, 2018
* added getProxy getProxy checks proxy settings from process.env.https_proxy or Yarn (NPM) config (.npmrc) * changed yarn for npm to get https-proxy default value for https-proxy is null, not undefined like in yarn
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user under proxy and didn't
set HTTP_PROXYvariable, create-react-app decides that user is offline and try to download packages from mirror, which are not here because you never download them (packages) before.This patch adds
getProxyfunction, that checks process.env.https_proxy and if it's undefined, will try to gethttps-proxysettings from Yarn (actually from npm) config file (.npmrc), if it's not defined yet, well we tried our best or you are offline.