Fix FileSizeReporter for multi build Webpack setups #3514
Conversation
If create-react-app project is ejected and webpack configuration is modified to multi build setup FileSizeReporter would fail. In those situations `webpackStats` parameter would contain stats array for each build. This fix will try to access stats and then falls back to using plaing webpackStats object.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for this one @iiska, I hope it'll be merged soon :) |
|
OK, looks reasonable. Thanks. |
If create-react-app project is ejected and webpack configuration is modified to multi build setup FileSizeReporter would fail. In those situations `webpackStats` parameter would contain stats array for each build. This fix will try to access stats and then falls back to using plaing webpackStats object.
FileSizeReporter would fail if create-react-app project is ejected and webpack configuration is
modified to multi build setup. This could be reproduced with webpack configuration which returns array of configuration objects.
Real world use case for that kind of setup could be implementing localization with separate builds for each language.
In those situations
webpackStatsparameter would contain stats arrayfor each build. This fix will try to access stats and then fallback to using plaing webpackStats object.
If stats array is found it is mapped through and flattened. Assets are handled like before.