Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolve to src folder #357

Closed
wants to merge 2 commits into from
Closed

Add resolve to src folder #357

wants to merge 2 commits into from

Conversation

viankakrisna
Copy link
Contributor

So we can write
import App from 'App'
instead of
import App from './App'

I think this will improve the developer experience of people using this kit :D

@ghost
Copy link

ghost commented Aug 4, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ghost
Copy link

ghost commented Aug 4, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed label Aug 4, 2016
@mxstbr
Copy link
Contributor

mxstbr commented Aug 4, 2016

This is a webpack-specific thing that people have to rely on in their App code, instead we'd love to use the NODE_PATH env var as that's a more portable solution. (there is an ongoing discussion in #253)

@gaearon
Copy link
Contributor

gaearon commented Aug 4, 2016

Yeah, happy to take a solution that works with NODE_PATH instead.

@gaearon gaearon closed this Aug 4, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants