Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom bit.ly links #3836

Merged
merged 5 commits into from
Jan 18, 2018
Merged

Use custom bit.ly links #3836

merged 5 commits into from
Jan 18, 2018

Conversation

bondz
Copy link
Contributor

@bondz bondz commented Jan 17, 2018

I verified the old links and the new links redirect to the same endpoint.

@bondz bondz changed the title Use custom links Use custom bit.ly links Jan 17, 2018
@@ -69,7 +69,7 @@ if (process.env.HOST) {
console.log(
`If this was unintentional, check that you haven't mistakenly set it in your shell.`
);
console.log(`Learn more here: ${chalk.yellow('http://bit.ly/2mwWSwH')}`);
console.log(`Learn more here: ${chalk.yellow('http://bit.ly/CRA-advanced-deploy')}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this CRA-advanced-config?

@Timer
Copy link
Contributor

Timer commented Jan 18, 2018

This is great, thank you!

@Timer Timer merged commit 9d67605 into facebook:next Jan 18, 2018
@Timer Timer added this to the 2.0.0 milestone Jan 18, 2018
@bondz bondz deleted the bondz-custom-links branch January 18, 2018 14:51
akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
* change link to advanced deployment

* Use custom CRA link for deployment

* use custom link for minification failure

* update link for deployment

* feedback
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
* change link to advanced deployment

* Use custom CRA link for deployment

* use custom link for minification failure

* update link for deployment

* feedback
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants