-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom bit.ly links #3836
Merged
Merged
Use custom bit.ly links #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timer
reviewed
Jan 18, 2018
@@ -69,7 +69,7 @@ if (process.env.HOST) { | |||
console.log( | |||
`If this was unintentional, check that you haven't mistakenly set it in your shell.` | |||
); | |||
console.log(`Learn more here: ${chalk.yellow('http://bit.ly/2mwWSwH')}`); | |||
console.log(`Learn more here: ${chalk.yellow('http://bit.ly/CRA-advanced-deploy')}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this CRA-advanced-config
?
This is great, thank you! |
akstuhl
pushed a commit
to akstuhl/create-react-app
that referenced
this pull request
Mar 15, 2018
* change link to advanced deployment * Use custom CRA link for deployment * use custom link for minification failure * update link for deployment * feedback
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
* change link to advanced deployment * Use custom CRA link for deployment * use custom link for minification failure * update link for deployment * feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified the old links and the new links redirect to the same endpoint.