Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESLint check for incorrect propTypes usage (#3840) #4048

Merged
merged 1 commit into from
Mar 25, 2018
Merged

Add ESLint check for incorrect propTypes usage (#3840) #4048

merged 1 commit into from
Mar 25, 2018

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Feb 20, 2018

Update eslint-plugin-react to 7.7.0 and add forbid-foreign-prop-types check.

Closes #3840

petetnt
petetnt approved these changes Feb 26, 2018
View reviewed changes
Copy link
Contributor

@petetnt petetnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denkristoffer denkristoffer mentioned this pull request Mar 2, 2018
Closed
@Timer Timer added this to the 2.0.0 milestone Mar 25, 2018
Timer
Timer approved these changes Mar 25, 2018
View reviewed changes
Copy link
Contributor

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iansu iansu merged commit 8a34b7c into facebook:next Mar 25, 2018
@renovate renovate bot mentioned this pull request Apr 9, 2018
Merged
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@iansu
Add ESLint check for incorrect propTypes usage (facebook#3840) (faceb…
037355c 
…ook#4048)
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
@iansu iansu deleted the forbid-foreign-prop-types branch October 18, 2019 05:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petetnt petetnt petetnt approved these changes

@Timer Timer Timer approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@iansu @Timer @petetnt @facebook-github-bot