Ignore Eslint errors in src/**/node_modules (allows package development inside /src without breaking ESLint and babel-loader)

[alex-pex]

Exclude node_modules from source compilation (babel + advanced feature).

This is a small change which allows package development without the whole lerna + babel toolkit : It's workspace package INSIDE src folder. Apart from the lint issue, everything else is working out-of-the-box!

---

DevServer shows warnings

Warnings disappear with my changes

[alex-pex]

The root package JSON looks like this (I split the main app from sub-packages)

{
  "name": "root",
  "version": "0.1.0",
  "private": true,
  "workspaces": [
    "src/app",
    "src/packages/*"
  ],

My folder structure looks like this

And importing globally accessible code is easy

I can even split dependencies as my app-ui-components and app-redux-store don't share the same requirements

{
  "name": "@app/store",
  "version": "0.1.0",
  "dependencies": {
    "@app/endpoints": "^0.1.0",
    "@app/state-machine": "^0.1.0",
    "deepmerge": "^2.2.1",
    "jwt-decode": "^2.2.0",
    "micromatch": "^3.1.10",
    "normalizr": "^3.3.0",
    "react-router": "^4.3.1",
    "redux-starter-kit": "^0.2.0",
    "xstate": "^4.2.1"
  },
  "peerDependencies": {
    "react": "16.*",
    "react-dom": "16.*"
  }
}

---

• Styleguidist works fine
• HMR too
• No babel watcher needed
• Lerna can be used to compile and publish packages but needs more tooling (I use it in another repository to publish UI components)

It's an easy workaround monorepo support drop
https://gist.github.com/gaearon/8650d1c70e436e5eff01f396dffc4114#monorepo-support-from-2x-alphas-was-removed-in-final-20

Feel free to discuss the pro and cons of my approach 🙂

---

Related issues :

• Can't use a CRA project inside Yarn Workspaces #3031
• Support importing files from outside of the root folder #5563

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[alex-pex]

This issue is not stale! And I found a similar issue with typescript detection occuring in src/**/node_modules. I don't have time yet to fix this issue as well

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[stale]

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

[alex-pex]

Thanks @iansu! Should I keep updating my PR to handle Typescript detection problem ?

Is it worth it ? I don't want to keep developing fixes if it ends up being ignored 😕

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.