Generated Sidebar Pagination will not use doc Label but the File Name

[LeonnardoVerol]

Have you read the Contributing Guidelines on issues?

• I have read the Contributing Guidelines on issues.

Prerequisites

• I'm using the latest version of Docusaurus.
• I have tried the npm run clear or yarn clear command.
• I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
• I have tried creating a repro with https://new.docusaurus.io.
• I have read the console error message carefully (if applicable).

Description

When generating pagination from the sidebar, the "Next" and "Previous" Cards will ignore the doc label and default to the file name. (when the doc has no H1 or Title property)

{
	type: 'doc',
	label: 'Quick Start',
	id: 'some_example_doc',
}

Reproducible demo

No response

Steps to reproduce

1. Create a doc without H1 or Title
2. Set the sidebar manually with the label property

Expected behavior

The generated Pagination would use the label property from the sidebar and not the file name

Actual behavior

The generated Pagination ignores the label property from the sidebar and uses the file name

Your environment

• Docusaurus version used: 3.1.0
• Environment name and version (e.g. Chrome 89, Node.js 16.4): Chrome 120
• Operating system and version (e.g. Ubuntu 20.04.2 LTS): Windows 11 Pro (Version 10.0.22631 Build 22631 )

Self-service

• I'd be willing to fix this bug myself.

[Josh-Cena]

Yes, something is wrong here.

docusaurus/packages/docusaurus-plugin-content-docs/src/sidebars/utils.ts

Lines 481 to 491 in cd0e608

	export function toDocNavigationLink(doc: DocMetadataBase): PropNavigationLink {
	const {
	title,
	permalink,
	frontMatter: {
	pagination_label: paginationLabel,
	sidebar_label: sidebarLabel,
	},
	} = doc;
	return {title: paginationLabel ?? sidebarLabel ?? title, permalink};
	}

Our doc navlink transform logic only takes into account the explicit sidebar_label front matter, but not the sidebar label acquired from the explicit sidebar label config. We need to fetch it from the SidebarNavigationItem we already calculated beforehand.

[Abdullah-03]

This should be the order of precedence, correct? Explicitly declared label should have higher priority over front matter.

title: paginationLabel ?? sidebarConfigLabel ?? sidebarLabel ?? title

[Abdullah-03]

side bar label in front matter takes precedence.