Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): Comparison with Rspress #10822

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

DevJoaoLopes
Copy link
Contributor

@DevJoaoLopes DevJoaoLopes commented Jan 6, 2025

Motivation

Adds comparison to rspress, helping other developers get a clearer view of the differences

Test Plan

preview

Test links

https://deploy-preview-10822--docusaurus-2.netlify.app/docs/#rspress

Related issues/PRs

Closes #10732

@facebook-github-bot
Copy link
Contributor

Hi @DevJoaoLopes!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Jan 6, 2025

[V2]

Name Link
🔨 Latest commit 2d43c2e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/677cfe5e3d1d730008005007
😎 Deploy Preview https://deploy-preview-10822--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 6, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 49 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🔴 49 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 73 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 46 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 73 🟢 100 🟢 100 🟠 86 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 6, 2025
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just editing a few things before merge

website/docs/introduction.mdx Outdated Show resolved Hide resolved
website/docs/introduction.mdx Outdated Show resolved Hide resolved
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 7, 2025
@slorber slorber changed the title docs: insert comparation for rspress docs(website): Comparison with Rspress Jan 7, 2025
@slorber slorber merged commit fcc9e5c into facebook:main Jan 7, 2025
13 of 14 checks passed
@DevJoaoLopes DevJoaoLopes deleted the docs/comparation-with-rspress branch January 8, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add rspress in Comparison with other tools section
3 participants