-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v1): remove exclusive language #1961
Conversation
Hi ericcarboni! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Deploy preview for docusaurus-2 ready! Built with commit e9520ac |
@ericcarboni why did you changes numbered lists? |
Deploy preview for docusaurus-preview ready! Built with commit e9520ac |
Whoops, my editor might have done that. Good catch! |
@ericcarboni can you revert these changes? |
Yeah, doing that now. Any idea why some lists are |
I do not know this, but I would leave only one notation |
One instance even had |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CLA signed! ✍️ |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you so much! We will probably want to change our tagline to make it more inclusive.
That's probably because there was a code block or something between the second 1 and the 3. Doing 1..1..3 will result in 1, 2, 3. Doing 1..1..1 will cause it to become 1, 2, 1 instead because the numbers are reset after the code block. |
Motivation
Similar to jestjs/jest#9040 by @carolstran, I wanted to take a stab at removing some language (easy, simply, of course, etc) to continue creating a more inclusive and friendly community.
It was difficult, however, because a lot of Docusaurus' goal is...
...so there were a lot branding references with the word "easy", so I kept those and also did not touch old blog posts.
Let me know what you think!
Have you read the Contributing Guidelines on pull requests?
Yes!
Test Plan
N/a no code changes
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)