refactor(v2): toggle data-theme with vanilla js instead of react helmet #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
added
the
pr: polish
endiliey
commented
Dec 15, 2019
| <> | ||
| <Head> | ||
| {/* TODO: Do not assume that it is in english language */} | ||
| <html lang="en" data-theme={theme} /> |
There was a problem hiding this comment.
If previously
Now
|
Deploy preview for docusaurus-2 ready! Built with commit eb937aa |
|
Deploy preview for docusaurus-preview ready! Built with commit eb937aa |
lex111
approved these changes
Dec 15, 2019
yangshun
approved these changes
Dec 16, 2019
| @@ -12,7 +12,7 @@ const path = require('path'); | |||
| const storageKey = 'theme'; | |||
| const noFlash = `(function() { | |||
| function setDataThemeAttribute(theme) { | |||
| document.querySelector('html').setAttribute('data-theme', theme); | |||
| document.documentElement.setAttribute('data-theme', theme); | |||
There was a problem hiding this comment.
For sure this is faster, it's direct access. But fewer people have heard about this lol. It's fine since it's internal.
There was a problem hiding this comment.
i think it is fine because relevant people can simply google and learn what this is
| @@ -14,7 +14,7 @@ function Link(props) { | |||
| const {to, href} = props; | |||
| const targetLink = to || href; | |||
| const isInternal = internalRegex.test(targetLink); | |||
| let preloaded = false; | |||
There was a problem hiding this comment.
Whoa this is such a bad bug, wonder how we didn't catch it earlier :|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactoring on
NavbarRefactoring on
LinkuseRefso that boolean persistuse
document.documentElementinstead ofqueryselector('html). Its faster according to benchmark i run https://jsperf.com/documentelevsquery/1Supported in all browsers https://developer.mozilla.org/en-US/docs/Web/API/document/documentElement
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
There shouldn't be difference in expected behavior ?
Toggling fine