-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v2): always exit after successful build #2443
Conversation
Deploy preview for docusaurus-2 ready! Built with commit f9fd76c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from async operations (e.g. setInterval
in custom React component). But in any case, the building must finishes successfully therefore LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks!
Motivation
When running
yarn build
, a successful build does not always exit as highlighted in the following issue #2431. We can achieve this by exiting when the build has finished.Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
yarn
andyarn build
build.js
ofhookstate
with the one fromdocusaurus v2
yard build
and the process exits instead of not exiting after build is successfulyarn build --out-dir build/nested
to ensure that the nested folder is generated and it works.(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)