Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): replace few Lodash methods with native counterparts #2529

Merged
merged 1 commit into from
Apr 5, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Apr 4, 2020

Motivation

This is a reworked version of #2520 PR, same motivation like in previous PRs.

This is the initial step in getting rid of main lodash package in favour of single method ones in core v2 Docusaurus package. In this PR _.assign, _.compact, _.flatten and _.isArray methods has been replaced with their native counterparts.

After applying those changes only has, isPlainObject and isString lodash packages are needed in the core.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Same test results before and after code refactor.

Related PRs

@Simek Simek requested a review from yangshun as a code owner April 4, 2020 09:30
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 4, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 2084e99

https://deploy-preview-2529--docusaurus-2.netlify.com

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Apr 4, 2020
@lex111 lex111 changed the title chore(v2): replace few Lodash methods with native counterparts refactor(v2): replace few Lodash methods with native counterparts Apr 4, 2020
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants