feat(v2): add blog post estimated reading time #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 27a5189 |
fanny
reviewed
Apr 4, 2020
There was a problem hiding this comment.
Hi @JoseRenan amazing work! ❤️ Just a detail, could you update the existing test with your new field?
yangshun
changed the title
yangshun
approved these changes
Apr 5, 2020
lex111
reviewed
Apr 5, 2020
packages/docusaurus-theme-classic/src/theme/BlogPostItem/index.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #2467
As described in #2467, it's very common to see on blogs the estimated reading time of posts, so the purpose of this change is to add the estimated reading time of blog posts in docusaurus.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Go to the blog page and the estimated reading time will be there:
You can also set the prop
showReadingTimeto false on the blog section ofdocusaurus.config.jsand the reading time will not be shown anymoreObservations
reading-timewhich is used by a similar plugin on gatsby to calculate the estimated reading time, but I think it can be calculated without a library 🤔