fix(v2): add a11y support for dropdown #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit c689e65 |
lex111
commented
Apr 27, 2020
| @@ -122,6 +122,7 @@ module.exports = { | |||
| href: 'https://github.com/facebook/docusaurus', | |||
| position: 'right', | |||
| className: 'header-github-link', | |||
| 'aria-label': 'GitHub repository', | |||
There was a problem hiding this comment.
Fixes a11y issue:
Links must have discernible text
|
I am merging this PR, because I think that these are safe changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After that, you can open dropdown (and navigate it) using the keyboard, this is good for accessibility.
In addition to that, in current PR, for consistency and easier code understanding, I changed the naming of some args and moved the custom CSS class to the end of the class list. This is a simple refactoring.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)