feat(v2): allow activeBaseTest in NavLink #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 6839fa0 |
lex111
reviewed
Apr 28, 2020
Co-Authored-By: Alexey Pyltsyn <[email protected]>
…relbug/docusaurus into feat/navbar-active-base-path
Co-Authored-By: Alexey Pyltsyn <[email protected]>
Co-Authored-By: Alexey Pyltsyn <[email protected]>
lex111
approved these changes
May 13, 2020
|
Any chance this could be merged? I'm looking forward to using this in my documentation website :) |
|
friendly ping @yangshun |
yangshun
approved these changes
May 17, 2020
|
Thanks @nebrelbug! Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #2683 and #2574
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Serving the Docusaurus v2 site works as expected. Adding
activeBaseTest: 'docs\\/(next|2\\.0\\.0\\-alpha\\.50)'to the "Docs" link indocusaurus.config.jsresults in the "Docs" link only being highlighted on the "next" and "alpha.50" versions.